Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): pass fully resolved path to nitro dist files #7494

Merged
merged 11 commits into from Sep 15, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14753

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR improves the testing for inlining nuxt assets in the build:

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 14, 2022
@danielroe danielroe requested a review from pi0 September 14, 2022 10:10
@danielroe danielroe self-assigned this Sep 14, 2022
@netlify
Copy link

netlify bot commented Sep 14, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 5be35d2
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6322e6d2821a1500088ca1bb

@pi0 pi0 force-pushed the main branch 3 times, most recently from 247e18b to c98e5c7 Compare September 14, 2022 10:41
@danielroe danielroe marked this pull request as draft September 14, 2022 14:13
@danielroe danielroe marked this pull request as ready for review September 15, 2022 08:55
@danielroe
Copy link
Member Author

I would like to iterate on this (moving some of this to build.transpile for example), but would be good to merge so https://github.com/vitejs/vite-ecosystem-ci will keep doing its good work.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM (i had been pending it for rc.11 to try on edge)

@@ -70,7 +70,8 @@ export async function initNitro (nuxt: Nuxt) {
nuxt.options.buildDir
]),
'nuxt/dist',
'nuxt3/dist'
'nuxt3/dist',
distDir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to exclude dist dir for prerender (will come with another PR if needed)

@pi0 pi0 merged commit 5855ba4 into main Sep 15, 2022
@pi0 pi0 deleted the fix/inline-dist branch September 15, 2022 11:24
@pi0 pi0 mentioned this pull request Sep 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt/app is treated as an external
2 participants