Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite, webpack): handle auto keys for composables without args #7651

Merged
merged 1 commit into from Sep 19, 2022
Merged

fix(vite, webpack): handle auto keys for composables without args #7651

merged 1 commit into from Sep 19, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A regression in earlier composable keys fix.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite webpack 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 19, 2022
@danielroe danielroe requested a review from pi0 September 19, 2022 14:43
@danielroe danielroe self-assigned this Sep 19, 2022
@netlify
Copy link

netlify bot commented Sep 19, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit cd320ab
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6328801a49e6380008bad360

@pi0
Copy link
Member

pi0 commented Sep 19, 2022

Do you mind to attach an example only for future reference?

@pi0 pi0 changed the title fix(vite, webpack): don't assume args are defined fix(vite, webpack): handle auto keys for composables without args Sep 19, 2022
@pi0 pi0 merged commit 42cf48e into main Sep 19, 2022
@pi0 pi0 deleted the fix/undefined-args branch September 19, 2022 14:45
@danielroe Volta.net
Copy link
Member Author 

const state = useState()
// no args

@pi0 pi0 mentioned this pull request Sep 20, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite webpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0