Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi, vite): support https with custom domain and hmr #7680

Merged
merged 2 commits into from Sep 20, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 20, 2022

πŸ”— Linked issue

Resolves nuxt/nuxt#14937

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Update listhen to respect custom hostname in display URL and expose resolved https options
  • Use custom https certificate for vite's hmr port to make it working out of the box

Note: Using temporary options.server namespace. Moving to options.devServer in a subsequent PR.

Example: (yes it works!)

yarn nuxi dev playground --host nuxt.fbi.com --https

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 20, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit fed0878
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6329952374038000089a4b53

@pi0 pi0 merged commit 720da64 into main Sep 20, 2022
@pi0 pi0 deleted the fix/nuxi-custom-host-ssl branch September 20, 2022 10:54
@pi0 pi0 mentioned this pull request Sep 20, 2022
@chrisnoden
Copy link

chrisnoden commented Sep 21, 2022

@pi0 If I use your example yarn nuxi dev playground --host nuxt.fbi.com --https but add -o to open the browser, the browser does not open to the provided host, it opens to localhost. This is a bug introduced in rc10 and mentioned in nuxt/nuxt#14937.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using custom host with https not possible
3 participants