Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: recommend to not overwrite some keys in tsconfig #7717

Merged
merged 2 commits into from Sep 21, 2022

Conversation

tobiasdiez
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I hit a strange error while upgrading from rc 9 to 11 that import_meta.hot.accept was not defined. After a bit of research, I think, I hit evanw/esbuild#2294. At least after removing "target": "ES2018", from the tsconfig file everything is working smoothly now. So I added a small note to the docs that these keys shouldn't be overwritten.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Sep 21, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 21, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit e7d9aa1
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/632b18fdc96a6a00098b679e
😎 Deploy Preview https://deploy-preview-7717--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe added the documentation Improvements or additions to documentation label Sep 21, 2022 — with Volta.net
Co-authored-by: Damian GΕ‚owala <48835293+DamianGlowala@users.noreply.github.com>
@pi0 pi0 merged commit daf99c3 into nuxt:main Sep 21, 2022
@pi0
Copy link
Member

pi0 commented Sep 21, 2022

Thanks!

@tobiasdiez tobiasdiez deleted the patch-1 branch September 21, 2022 14:31
@manniL manniL mentioned this pull request Sep 23, 2022
4 tasks
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants