Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: add newline at end of sass import #7810

Merged
merged 2 commits into from Sep 30, 2022
Merged

docs: add newline at end of sass import #7810

merged 2 commits into from Sep 30, 2022

Conversation

Fumihiro-Yano
Copy link
Contributor

@Fumihiro-Yano Fumihiro-Yano commented Sep 25, 2022 •
edited by DamianGlowala

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Sass import needs newline code.

The following error will be displayed if the line feed code is within

[sass] expected newline.                                                                                                   
  β•·
1 β”‚ @use "@/assets/_colors.sass" as *abbr,
  β”‚                                       ^
  β•΅
  assets/styles/reset.sass 1:39  root stylesheet

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Fumihiro-Yano
【Update】Sass import needs newline code.
4b58791 
Sass import needs newline code.

The following error will be displayed if the line feed code is within

```
[sass] expected newline.                                                                                                   
  β•·
1 β”‚ @use "@/assets/_colors.sass" as *abbr,
  β”‚                                       ^
  β•΅
  assets/styles/reset.sass 1:39  root stylesheet
```
@codesandbox
Copy link

codesandbox bot commented Sep 25, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 25, 2022 •
edited

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 550cdd6
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/633186c7e6ee8a0008577f5a
😎 Deploy Preview https://deploy-preview-7810--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Fumihiro-Yano Fumihiro-Yano changed the title 【Update】Sass import needs newline code. docs: Sass import needs newline code. Sep 25, 2022
@Fumihiro-Yano Fumihiro-Yano changed the title docs: Sass import needs newline code. docs: sass import needs newline code. Sep 25, 2022
@DamianGlowala DamianGlowala changed the title docs: sass import needs newline code. docs: Sass import needs newline character Sep 25, 2022
@DamianGlowala DamianGlowala added the documentation Improvements or additions to documentation label Sep 25, 2022
@danielroe danielroe changed the title docs: Sass import needs newline character docs: add newline at end of sass import Sep 25, 2022
@DamianGlowala
Copy link
Member

I'm wondering whether the whitespace prepending \n is needed?

@Atinux Atinux merged commit bea2848 into nuxt:main Sep 30, 2022
@Fumihiro-Yano Fumihiro-Yano deleted the patch-1 branch October 4, 2022 04:40
@danielroe danielroe mentioned this pull request Oct 9, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielroe danielroe danielroe approved these changes

@Atinux Atinux Atinux approved these changes

Assignees
No one assigned
Labels
3.x documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fumihiro-Yano @DamianGlowala @Atinux @danielroe