Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(test-utils): respect setupTimeout #7866

Merged
merged 1 commit into from Oct 3, 2022
Merged

fix(test-utils): respect setupTimeout #7866

merged 1 commit into from Oct 3, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14159

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Previously we were not doing anything with setupTimeout, but hard coding the setup length.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils labels Sep 27, 2022
@danielroe danielroe requested a review from pi0 September 27, 2022 13:55
@danielroe danielroe self-assigned this Sep 27, 2022
@codesandbox
Copy link

codesandbox bot commented Sep 27, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 27, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 1b83a9b
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/633300be9a3b3e0008356e9c

@Atinux Atinux self-requested a review September 27, 2022 14:26
@Atinux Atinux merged commit dab1b11 into main Oct 3, 2022
@Atinux Atinux deleted the fix/test-timeout branch October 3, 2022 13:48
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage test-utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement setupTimeout option in test-utils
2 participants