This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
chore: use pnpm for framework monorepo #7895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
chore
π§Ή p1-chore
Priority 1: no change in change code behavior
labels
Sep 28, 2022
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8 tasks
danielroe
force-pushed
the
chore/pnpm
branch
2 times, most recently
from
October 9, 2022 20:52
b097058
to
2660d11
Compare
pi0
reviewed
Oct 16, 2022
ugh - sorry, didn't mean to overwrite your authoring of the commits π |
(avoid lockfile changes as they are breaking)
pi0
approved these changes
Oct 17, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
https://github.com/nuxt/framework/discussions/939
β Type of change
π Description
We've been discussing migrating to pnpm in our move towards full pnpm support. This PR implements it using
--shamefully-hoist
and--strict-peer-dependencies=false
; we can remove these flags when possible.We also have the opportunity to lose a lot of weight in the monorepo if we remove(lerna replaced with local scripts for bumping rc)lerna
- not sure how possible that is @pi0 but worth mentioning; it's now only used for the actual release.Contributors notes
If you have already cleaned the repository locally, run this to migrate:
You can also safely remove top level
.yarn
directory.Script updates:
yarn stub
script is changed topnpm build:stub
yarn dev
script is changed topnpm play
π Checklist