Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

chore: use pnpm for framework monorepo #7895

Merged
merged 32 commits into from Oct 17, 2022
Merged

chore: use pnpm for framework monorepo #7895

merged 32 commits into from Oct 17, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Sep 28, 2022

πŸ”— Linked issue

https://github.com/nuxt/framework/discussions/939

❓ Type of change

  • 🧹 Chore
  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We've been discussing migrating to pnpm in our move towards full pnpm support. This PR implements it using --shamefully-hoist and --strict-peer-dependencies=false; we can remove these flags when possible.

We also have the opportunity to lose a lot of weight in the monorepo if we remove lerna - not sure how possible that is @pi0 but worth mentioning; it's now only used for the actual release. (lerna replaced with local scripts for bumping rc)

Contributors notes

If you have already cleaned the repository locally, run this to migrate:

npm run cleanup && corepack enable && pnpm install && pnpm build:stub

You can also safely remove top level .yarn directory.

Script updates:

  • yarn stub script is changed to pnpm build:stub
  • yarn dev script is changed to pnpm play

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added chore 🧹 p1-chore Priority 1: no change in change code behavior labels Sep 28, 2022
@danielroe danielroe requested a review from pi0 September 28, 2022 21:14
@danielroe danielroe self-assigned this Sep 28, 2022
@codesandbox
Copy link

codesandbox bot commented Sep 28, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 28, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 86279cb
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/634d27cb4a0d5b000875df3a
😎 Deploy Preview https://deploy-preview-7895--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe marked this pull request as ready for review September 28, 2022 21:38
@Atinux
Copy link
Member

Atinux commented Oct 3, 2022

This is really convincing as well as pnpm speed πŸš€

CleanShot 2022-10-03 at 15 39 42@2x

@danielroe danielroe force-pushed the chore/pnpm branch 2 times, most recently from b097058 to 2660d11 Compare October 9, 2022 20:52
netlify.toml Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Oct 16, 2022

Netlify build seems going wrong (not related to pnpm but since deps are now shared it is happening)
image

3:12:12 PM: [error] [nuxt] [request error] [unhandled] [500] app.ssrContext.nuxt.vueApp.config.globalProperties.$pinceauSsr.get is not a function

pinceauSsr usage wrong?

3:12:12 PM: [error] [nuxt] [request error] [unhandled] [500] Cannot read properties of undefined (reading 'url')

Hint: useQuery is called with req instead of event somewhere (github module and another place)

@danielroe
Copy link
Member Author

ugh - sorry, didn't mean to overwrite your authoring of the commits πŸ™ˆ

(avoid lockfile changes as they are breaking)
@pi0 pi0 changed the title chore: migrate to pnpm chore: use pnpm for framework monorepo Oct 17, 2022
@pi0 pi0 merged commit 74a90c5 into main Oct 17, 2022
@pi0 pi0 deleted the chore/pnpm branch October 17, 2022 10:10
@pi0 pi0 mentioned this pull request Oct 18, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x chore 🧹 p1-chore Priority 1: no change in change code behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants