Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): add type-checker to client build for ssr: false #7930

Merged
merged 2 commits into from Oct 3, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14586

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If there is no server build, currently type checker isn't applied. This PR falls back to checking client build.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 30, 2022
@danielroe danielroe requested a review from pi0 September 30, 2022 13:22
@danielroe danielroe self-assigned this Sep 30, 2022
@codesandbox
Copy link

codesandbox bot commented Sep 30, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Sep 30, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 8e0d3fc
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/633ae558ebc5da0008178e81

@Atinux Atinux merged commit d25dafe into main Oct 3, 2022
@Atinux Atinux deleted the fix/typecheck-spa branch October 3, 2022 13:37
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typeCheck only handles server build
2 participants