Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: add app.config route to pre-render #8131

Merged
merged 6 commits into from Oct 12, 2022
Merged

docs: add app.config route to pre-render #8131

merged 6 commits into from Oct 12, 2022

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Oct 12, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add missing url not detected by crawler πŸ€”

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Oct 12, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 12, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6346e24ab970b627c0d45d40
😎 Deploy Preview https://deploy-preview-8131--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Atinux Atinux requested a review from danielroe October 12, 2022 10:49
@danielroe
Copy link
Member

Hm. We need to handle 404 page:

CleanShot 2022-10-12 at 12 14 37

@Tahul
Copy link
Contributor

Tahul commented Oct 12, 2022

https://github.com/nuxt/content/blob/main/src/runtime/pages/document-driven.vue

Docus has no "default" components for DocumentDrivenNotFound and DocumentDrivenEmpty components, but I guess this is the way to go for this kind of issues.

I remember that there was an "issue" (maybe this is expected behavior) with catch-all pages that was overriding the support for error pages in pages folder.

Maybe we could work around this by throwing an error in DocumentDriven page when the query fails, and then handling the 404 via Nuxt pages folder?

I also know that as pagesaren't "extendable", the only way of allowing user to overwrite was to use replaceable components (DocumentDrivenNotFound...).

@danielroe
Copy link
Member

If we have a design for a custom error page, we can provide it in ~/error.vue in this repo.

The 404 error is only being thrown on server side in docus, which means we're not redirected to it on a client-side 404 (in this case), and the console errors are coming from missing nav data (owing to not having a defined GITHUB_TOKEN) on client side. We should likely gracefully handle them as well.

@Atinux
Copy link
Member Author

Atinux commented Oct 12, 2022

It the comment blocking the current PR?

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is good to go πŸ‘

@Tahul
Copy link
Contributor

Tahul commented Oct 12, 2022

Just a little info, this can only be reproduced on built version, when using dev, landing on undefined link will display 404/error page

I just locally tried creating both:

docs/error.vue
// or
docs/pages/error.vue

It doesn't had any effect in built versions, I suspect this is upstream issue as mentioned, error.vue page won't be taken in account when catch-all page already setup.

@Atinux Atinux merged commit a6e4a09 into main Oct 12, 2022
@Atinux Atinux deleted the docs/404 branch October 12, 2022 16:45
This was referenced Oct 12, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants