Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt)!: refresh to override previous requests by default #8190

Merged
merged 1 commit into from Oct 15, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#7864

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This renames override to dedupe and enables it by default, which should be more the expected behaviour.

πŸ‘‰ Migration

If you were relying on the previous behaviour (not re-calling a fetch function if one was already running) then you can update your refresh calls like so:

- refresh()
+ refresh({ dedupe: false })

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Oct 14, 2022
@danielroe danielroe requested a review from pi0 October 14, 2022 13:19
@danielroe danielroe self-assigned this Oct 14, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 14, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 14, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 6210c22
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/634961fd5562210008bbd226
😎 Deploy Preview https://deploy-preview-8190--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally still believe cancel: false is easier to read than dedup: true but both are good....

@pi0 pi0 merged commit d862a6b into main Oct 15, 2022
@pi0 pi0 deleted the feat/override-default branch October 15, 2022 11:02
@pi0 pi0 mentioned this pull request Oct 18, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants