fix(nuxt): fix broken external urls when baseURL is set in config

[Araneline]

🔗 Linked issue

nuxt/nuxt#15082

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves nuxt/nuxt#15082 - set baseURL for ohmyfetch dynamically through interceptor. The urls were prefixed with baseURL even if they were external.

Using onRequest method of ohmyfetch we set a request interceptor which checks for:

• http(-s) at the beginning of request url
• not set baseURL in options

If both are true, it sets the baseURL to '' (allowing external link calls). Otherwise if not already in request config - sets the baseURL

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[netlify]

✅ Deploy Preview for nuxt3-docs canceled.

Name	Link
🔨 Latest commit	62a70a1
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt3-docs/deploys/6349ecfabd072c00095085a7

[danielroe]

This seems like an upstream bug to me, and we should likely resolve in ufo or ohmyfetch.

Previously we had a similar bug which was resolved in unjs/ufo#68.

-> also posted in https://github.com/nuxt/framework/issues/7983#issuecomment-1279743702

[Araneline]

This seems like an upstream bug to me, and we should likely resolve in ufo or ohmyfetch.

Previously we had a similar bug which was resolved in unjs/ufo#68.

-> also posted in nuxt/nuxt#15082

Ok. Would you mind if I had a look at ufo and try to fix it there? Alternatively I can close this PR.

[danielroe]

Taking a look upstream would be lovely 😊

[Araneline]

Quick update/note: seems like the issue is boiled down to withBase method from ufo which is used if baseURL is set in ohmyfetch.

[Araneline]

@danielroe the fix to that problem was already committed 3 months ago to the unjs/ufo. There was a patch which introduced check for hasProtocol alongside isEmptyURL in withBase function.

Looking at unjs/ohmyfetch repo after pnpm install, it's clear that the old version of the ufo is installed since there's no hasProtocol check.

The solution: update the version of unjs/ufo in unjs/fetch (probably releasing a new version first for ufo).

This branch can be safely disregarded after that.

[danielroe]

Thanks for investigating. ❤️🙏

[danielroe]

@pi0 shall i release new versions of ufo and ohmyfetch?

[pi0]

ufo@0.8.6 is released. The latest release of ohmyfetch has the compatible semver range dependency on ufo 0.8x. Please try recreating lockfile. It should fix the issue.