Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): remove workspaceDir from tsconfig include #8256

Merged
merged 1 commit into from Oct 17, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#15165

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

By default we include workspace in include paths (#7726) but this may lead to over-type-checking in monorepos. This PR reverts this behaviour and puts it behind an option which can be enabled by default in module author template.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working dx labels Oct 17, 2022
@danielroe danielroe requested a review from pi0 October 17, 2022 15:26
@danielroe danielroe self-assigned this Oct 17, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 17, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 17, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 80d29dc
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/634d743bd67cfd00087a1f0f

@danielroe danielroe changed the title fix(nuxi): include workspaceDir in tsconfig include fix(nuxi): remove workspaceDir from tsconfig include Oct 17, 2022
@pi0 pi0 merged commit 931ebec into main Oct 17, 2022
@pi0 pi0 deleted the fix/workspace-ts branch October 17, 2022 17:53
@pi0 pi0 mentioned this pull request Oct 18, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working dx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.0.0-rc.12 typecheck runs throughout monorepo
2 participants