Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(kit): addVitePlugin addWebpackPlugin support plugin array #8270

Merged
merged 2 commits into from Oct 18, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Oct 18, 2022

πŸ”— Linked issue

#8265

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

An array of plugins is also a valid Vite plugin, we should support that.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Oct 18, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 18, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 1a682ce
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/634e6cb7bedf0700092855d5

@pi0
Copy link
Member

pi0 commented Oct 18, 2022

Shall we support for addWebpackPlugin too?

@antfu antfu changed the title feat(kit): addVitePlugin supports plugin array feat(kit): addVitePlugin addWebpackPlugin support plugin array Oct 18, 2022
@antfu
Copy link
Member Author

antfu commented Oct 18, 2022

Unplugin's Webpack plugin behaviours like one so we don't directly need it, but sure why not. Changed pushed.

@pi0 pi0 merged commit 6567ac3 into main Oct 18, 2022
@pi0 pi0 deleted the feat/add-vite-plugin-array branch October 18, 2022 09:09
@pi0 pi0 mentioned this pull request Oct 18, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants