This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
perf(nuxt): use simple JSON.stringify
to compare params
#8340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#8327
β Type of change
π Description
Using
JSON.stringify
to compare two route params as suggested by @Atinux. It saves 1.53Kb gzip (~1.6%) bundle size when pages are enabled by not importingohash
. Difference is that we assume order of params remains same.Note: we probably need this library in other places in the future such as
useFetch
if depending on URL again (#6632).π Checklist