Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): invalidate virtual modules with vite-node #8389

Merged
merged 1 commit into from Oct 24, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 21, 2022

πŸ”— Linked issue

resolves nuxt/nuxt#15141, resolves nuxt/nuxt#15045

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We invalidate virtual files in the vite server whenever templates are regenerated. But hitherto we weren't invalidating them in vite-node.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 21, 2022
@danielroe danielroe requested review from pi0 and antfu October 21, 2022 11:57
@danielroe danielroe self-assigned this Oct 21, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 21, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 21, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit ae6f8ef
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63528914fa992900093326ed

@pi0 pi0 merged commit 4536242 into main Oct 24, 2022
@pi0 pi0 deleted the fix/invalidate-vite-node branch October 24, 2022 08:32
@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routes not registered when page file created router not updating with new routes on HMR
3 participants