Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): avoid directly importing vue-router inside <NuxtLayout> #8421

Merged
merged 3 commits into from Oct 24, 2022
Merged

fix(nuxt): avoid directly importing vue-router inside <NuxtLayout> #8421

merged 3 commits into from Oct 24, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#15236

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As noted in #8133, this follows up to remove a vue-router dependency from all use of <NuxtLayout>.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working pages 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 23, 2022
@danielroe danielroe self-assigned this Oct 23, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 23, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 23, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit f2e3b21
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63564be29844660009e7734f

@danielroe danielroe requested a review from pi0 October 24, 2022 08:25
@pi0 pi0 changed the title fix(nuxt): don't use vue-router without pages/ integration fix(nuxt): avoid directly importing vue-router inside <NuxtLayout> Oct 24, 2022
@pi0 pi0 merged commit 6bcd9cd into main Oct 24, 2022
@pi0 pi0 deleted the fix/router-layout branch October 24, 2022 08:36
@pi0 pi0 mentioned this pull request Nov 3, 2022
Merged
@misaon misaon mentioned this pull request Nov 11, 2022
Closed
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Atinux Atinux Atinux approved these changes

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<NuxtLayout> does not work without pages/ integration
3 participants
@danielroe @Atinux @pi0