Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor(schema)!: disable app.pageTransition and app.layoutTransition by default #8436

Merged
merged 5 commits into from Oct 24, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#8434 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This disables page/layout transitions by default. They cause issues like nuxt/nuxt#13471 and nuxt/nuxt#15239 when many users may not be using them at all ...

Β πŸ‘‰ Migration

If you were using page/layout transitions, you can add the following to your nuxt config to re-enable the previous behaviour:

export default defineNuxtConfig({
  app: {
    pageTransition: { name: 'page', mode: 'out-in' },
    layoutTransition: { name: 'layout', mode: 'out-in' }
  },
})

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested review from Atinux and pi0 October 24, 2022 08:50
@danielroe danielroe self-assigned this Oct 24, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 24, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 24, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit e47c6b0
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63566e1a2300040009fc0b2e
😎 Deploy Preview https://deploy-preview-8436--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

Atinux commented Oct 24, 2022

Thank you @danielroe

We need to update the documentation as well (https://v3.nuxtjs.org/getting-started/transitions) to explain how to enable page transition and layouts transitions.

@danielroe
Copy link
Member Author

Thank you - good catch! πŸ™

@pi0 pi0 changed the title fix(schema)!: disable page/layout transitions by default fix(schema)!: disable app.pageTransition and app. layoutTransition by default Oct 24, 2022
@pi0 pi0 changed the title fix(schema)!: disable app.pageTransition and app. layoutTransition by default refactor(schema)!: disable app.pageTransition and app. layoutTransition by default Oct 24, 2022
@danielroe danielroe changed the title refactor(schema)!: disable app.pageTransition and app. layoutTransition by default refactor(schema)!: disable app.pageTransition and app.layoutTransition by default Oct 24, 2022
@danielroe
Copy link
Member Author

danielroe commented Oct 24, 2022

Fixing test failure. On plane, so may take a minute.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants