This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(kit): use pathe to resolve aliases
#8453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
commented
Oct 25, 2022
Atinux
approved these changes
Oct 25, 2022
pi0
reviewed
Oct 25, 2022
| @@ -106,13 +106,7 @@ export function resolveAlias (path: string, alias?: Record<string, string>): str | |||
| if (!alias) { | |||
| alias = tryUseNuxt()?.options.alias || {} | |||
| } | |||
| for (const key in normalizeAliases(alias)) { | |||
| if (key === '@' && !path.startsWith('@/')) { continue } // Don't resolve @foo/bar | |||
There was a problem hiding this comment.
Note that we have removed @ and @/ check from pathe util
There was a problem hiding this comment.
But we now respect path separate which should do the same thing.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14735
❓ Type of change
📚 Description
We have some upstream fixes in
pathe/utilsthat we can take advantage of in kit.📝 Checklist