Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(kit): don't require nuxt when resolving path #8504

Merged
merged 1 commit into from Oct 26, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently if nuxt instance is not present when calling resolvePath, we will throw an error. We already check for existence, so this was likely not intended.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working kit labels Oct 26, 2022
@danielroe danielroe requested a review from pi0 October 26, 2022 13:53
@danielroe danielroe self-assigned this Oct 26, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 26, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 26, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 73f4be7
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63593bf900a36e00084ea49f

@pi0 pi0 merged commit 2284525 into main Oct 26, 2022
@pi0 pi0 deleted the fix/resolve-path-nuxt-optional branch October 26, 2022 13:55
@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants