Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(kit): normalize nitro handler paths #8626

Merged
merged 1 commit into from Nov 3, 2022
Merged

fix(kit): normalize nitro handler paths #8626

merged 1 commit into from Nov 3, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 2, 2022 •
edited

🔗 Linked issue

Baroshem/nuxt-security#42

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This normalizes paths to handlers passed in via addServerHandler and addDevServerHandler.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite kit labels Nov 2, 2022
@danielroe danielroe requested a review from pi0 November 2, 2022 14:09
@danielroe danielroe self-assigned this Nov 2, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 2, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 2, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 285d3db
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63627a2eb75a910008ed6729

pi0
pi0 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we may need to apply this patch from nitro as well to handle similar edge cases)

@pi0 pi0 merged commit 7c4899a into main Nov 3, 2022
@pi0 pi0 deleted the fix/normalise-paths branch November 3, 2022 14:04
@pi0 pi0 mentioned this pull request Nov 3, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

@Baroshem Baroshem Baroshem approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working kit vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielroe @pi0 @Baroshem