Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): enable fs strict mode #8674

Merged
merged 2 commits into from Nov 3, 2022
Merged

fix(vite): enable fs strict mode #8674

merged 2 commits into from Nov 3, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 3, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Enable vite fs restriction by default. This ensures avoiding access to fs using /_nuxt/@fs/ url.

Read more: https://vitejs.dev/config/server-options.html#server-fs-strict).

This PR might introduce issues with modules trying to access outside of rootDir, srcDir, buildDir, workspaceDir or either of modulesDir (modules are automatically added). In this case, can be manually added using nuxt.options.vite.server.fs.allow[]

export default defineNuxtConfig({
  vite: {
    server: {
      fs: {
        allow: [
          '/xyz'
        ]
      }
    }
  }
})

Credits to @OhB00 for discovering this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 3, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 3, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit bf0013e
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6364382b6c5da00009cff70c

@pi0 pi0 merged commit 44b4100 into main Nov 3, 2022
@pi0 pi0 deleted the fix/vite-fs-strict branch November 3, 2022 22:03
@pi0 pi0 mentioned this pull request Nov 3, 2022
@manniL
Copy link
Member

manniL commented Nov 4, 2022

This only has impact in dev mode, right?

@OhB00
Copy link
Contributor

OhB00 commented Nov 4, 2022

This only has impact in dev mode, right?

Correct, you can read the full report on huntr when it is published.

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants