This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): check if global transitions are activated for scroll behavior #8700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a regression from #8463 Learn more in the comments from #8327
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
7 tasks
pi0
reviewed
Nov 4, 2022
7 tasks
pi0
approved these changes
Nov 4, 2022
pi0
changed the title
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a regression from #8463
And resolves nuxt/nuxt#15364
Learn more in the comments from #8327
❓ Type of change
📚 Description
Regression since we need to detect if there are global transitions activated in order to listen to
page:transition:finishhook. Otherwise it's never called and the scrollBehavior is inactive.Also, since the value of the next and previous page can be
undefined, using!== falsewas also a wrong usage.