Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix: correct default scroll behavior for routes without page transition #8701

Closed
wants to merge 1 commit into from
Closed

fix: correct default scroll behavior for routes without page transition #8701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nuxt/src/pages/runtime/router.options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default <RouterConfig> {
}

// Wait for `page:transition:finish` or `page:finish` depending on if transitions are enabled or not
const hasTransition = to.meta.pageTransition !== false && from.meta.pageTransition !== false
const hasTransition = !!(to.meta.pageTransition && from.meta.pageTransition)
const hookToWait = hasTransition ? 'page:transition:finish' : 'page:finish'
return new Promise((resolve) => {
nuxtApp.hooks.hookOnce(hookToWait, async () => {
Expand Down