Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): allow cookies to be set to null to unset them #8769

Merged
merged 5 commits into from Nov 9, 2022
Merged

fix(nuxt): allow cookies to be set to null to unset them #8769

merged 5 commits into from Nov 9, 2022

Commits on Nov 6, 2022

  1. Fixed cookie value type 

    ### Discussed in https://github.com/nuxt/framework/discussions/2576

The cookie.value is typed as string, so // @ts-ignore must be used to do this. I have fixed the types, so the cookie can be deleted without a ts error.
    @magyarb
    magyarb committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    cc1df3e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. fix: add null directly to Ref generic

    @danielroe
    danielroe committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d4211ab View commit details
    Browse the repository at this point in the history

  2. test: add test for unsetting cookie

    @danielroe
    danielroe committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8b47270 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into patch-1

    @danielroe
    danielroe committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    35a1c2e View commit details
    Browse the repository at this point in the history

  4. test: add back missed line

    @danielroe
    danielroe committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    436d7f2 View commit details
    Browse the repository at this point in the history