Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): add catchall paths to prerender list #8782

Merged
merged 2 commits into from Nov 9, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Where users had only a catchall but no other pages, we weren't generating anything. In this case we can almost certainly render the base URL that would otherwise be caught by the catchall. (I've also included optional params, e.g. ~/pages/[[something]].vue.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Nov 7, 2022
@danielroe danielroe requested review from Atinux and pi0 November 7, 2022 18:00
@danielroe danielroe self-assigned this Nov 7, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 7, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 7, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit d83621b
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636947a6d4f8fe0009b17541

@pi0 pi0 changed the title fix(nuxt): add catchall/optional paths to prerender list fix(nuxt): add catchall paths to prerender list Nov 9, 2022
@pi0 pi0 merged commit 30d9947 into main Nov 9, 2022
@pi0 pi0 deleted the fix/catchall-generation branch November 9, 2022 09:00
@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants