Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(schema): add declarations to ignore list #8787

Merged
merged 4 commits into from Nov 9, 2022
Merged

fix(schema): add declarations to ignore list #8787

merged 4 commits into from Nov 9, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#15387

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We can safely ignore .d.ts files from our resolver for layouts, pages, middleware, plugins, etc. (and indeed from the vite build watcher). They will still be included in the user's project and type checked.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working schema labels Nov 7, 2022
@danielroe danielroe requested a review from pi0 November 7, 2022 21:48
@danielroe danielroe self-assigned this Nov 7, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 7, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 7, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 9b80b35
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636983686662d900086dbd90

@danielroe danielroe changed the title style: lint some types fix(schema): add declarations to ignore list Nov 7, 2022
@danielroe danielroe changed the title fix(schema): add declarations to ignore list fix(schema): add declarations to ignore list Nov 7, 2022
@danielroe danielroe marked this pull request as ready for review November 7, 2022 21:54
@pi0 pi0 merged commit 4e8f59b into main Nov 9, 2022
@pi0 pi0 deleted the fix/ignore-ts branch November 9, 2022 09:01
@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining an index.d.ts file in /plugins throws an error client-side
2 participants