This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): treeshake client-only components with placeholders #8789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
8 tasks
danielroe
approved these changes
Nov 15, 2022
danielroe
added
bug
danielroe
changed the title
|
I do plan to merge the other PR but we shouldn't hold this one up. Thank you again! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolve nuxt/nuxt#15396
❓ Type of change
📚 Description
Hi 👋 currently the tree-shake module does not treeshake .client components due to #7412 that adds
ServerPlaceholderas .client components server side component.This PR fix the RegexpMap of the treeshake module by adding a condition to verify that
other.filePathis not the path toServerPlaceholder.btw this can be closed if #8713 pass
📝 Checklist