Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): exclude dist from type checking #8848

Merged
merged 3 commits into from Nov 10, 2022
Merged

fix(nuxi): exclude dist from type checking #8848

merged 3 commits into from Nov 10, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#15415

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

.nuxt/dist, .output, .netlify, etc. aren't caught because they start with ., but the 'dist' folder does get caught by TS when type-checking a project. Excluding it should improve type-checking performance, and also resolve the linked issue.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working cli labels Nov 9, 2022
@danielroe danielroe requested a review from pi0 November 9, 2022 11:16
@danielroe danielroe self-assigned this Nov 9, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 9, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 9, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit f730708
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636ba730ff24ed0008f13494

@pi0 pi0 changed the title fix(nuxi): exclude 'dist' from type checking fix(nuxi): exclude dist from type checking Nov 10, 2022
@pi0 pi0 merged commit c32c1d0 into main Nov 10, 2022
@pi0 pi0 deleted the fix/exclude-dist branch November 10, 2022 08:45
@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$fetch typings clash with contents of dist folder
2 participants