Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): use app.baseURL when fetching error page on server #8888

Merged
merged 2 commits into from Nov 10, 2022
Merged

fix(nuxt): use app.baseURL when fetching error page on server #8888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a331343
fix(nuxt): use `app.baseURL` when fetching error page on server
Nov 10, 2022
3c5747b
Merge branch 'main' into fix/ssr-error-page-base-url
tobyfaux Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/nuxt/src/core/runtime/nitro/error.ts
View file
Open in desktop
@@ -1,7 +1,7 @@
import { withQuery } from 'ufo'
import { joinURL, withQuery } from 'ufo'
import type { NitroErrorHandler } from 'nitropack'
import { H3Error, setResponseHeader, getRequestHeaders } from 'h3'
import { useNitroApp } from '#internal/nitro'
import { useNitroApp, useRuntimeConfig } from '#internal/nitro'
import { normalizeError, isJsonRequest } from '#internal/nitro/utils'

export default <NitroErrorHandler> async function errorhandler (error: H3Error, event) {
Expand Down Expand Up @@ -47,7 +47,7 @@ export default <NitroErrorHandler> async function errorhandler (error: H3Error,
// HTML response (via SSR)
const isErrorPage = event.req.url?.startsWith('/__nuxt_error')
const res = !isErrorPage
? await useNitroApp().localFetch(withQuery('/__nuxt_error', errorObject), {
? await useNitroApp().localFetch(withQuery(joinURL(useRuntimeConfig().app.baseURL, '/__nuxt_error'), errorObject), {
headers: getRequestHeaders(event) as Record<string, string>,
redirect: 'manual'
}).catch(() => null)
Expand Down