Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: match the open graph protocol markup #8959

Merged
merged 1 commit into from Nov 14, 2022
Merged

Conversation

IsraelOrtuno
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

https://ogp.me/ suggests to use the attribute property instead of name when defining OpenGraph metadata.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

https://ogp.me/ suggests to use the attribute `property` instead of `name` for defining its properties
@codesandbox
Copy link

codesandbox bot commented Nov 14, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 14, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 9c4d544
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6371be6e5401f600083e06a1
😎 Deploy Preview https://deploy-preview-8959--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe
Copy link
Member

Thank you ❀️

@pi0 pi0 changed the title docs: Match the OpenGraph protocol markup docs: match the open graph protocol markup Nov 14, 2022
@pi0 pi0 merged commit 4915a39 into nuxt:main Nov 14, 2022
@manniL
Copy link
Member

manniL commented Nov 14, 2022

@harlan-zw Maybe unhead could allow both, name or property and automatically choose the right one (e.g. property for og: tags, name otherwise?)

@harlan-zw
Copy link
Collaborator

@harlan-zw Maybe unhead could allow both, name or property and automatically choose the right one (e.g. property for og: tags, name otherwise?)

The logic for determining that is actually quite complex (like 1kb of scripts), so instead, we implement this type of logic in a opt-in composable.

https://unhead.harlanzw.com/guide/guides/useseometa

PR should be up very shortly

@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants