Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor: update unjs dependencies to stable v1 #9011

Merged
merged 8 commits into from Nov 15, 2022
Merged

refactor: update unjs dependencies to stable v1 #9011

merged 8 commits into from Nov 15, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 15, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Update uns packages with semver major to v1.

Also updating nitropack temporarily to edge channel to finish update in one step.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 15, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 15, 2022

❌ Deploy Preview for nuxt3-docs failed.

Name Link
πŸ”¨ Latest commit 6918f57
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6373a2c66a64c20009a94ffa

@manniL
Copy link
Member

manniL commented Nov 15, 2022

@pi0 Could you briefly explain why was ohmyfetch renamed to ofetch? I'm a little afraid people have to memorize "yet another library name" after getting used to ohmyfetch + using it package in projects / shown it in docs + talks πŸ™ˆ

@pi0 pi0 mentioned this pull request Nov 15, 2022
@pi0
Copy link
Member Author

pi0 commented Nov 15, 2022

Could you briefly explain why was ohmyfetch renamed to ofetch?

it is a shorter name. I initially wanted to release as shorter name but took long to get publish access to it. As for Nuxt users, interface name is still $fetch without imports. Perhaps can add some references to ofetch readme to explain renaming.

@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

🧐 Potential typo squat

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Package πŸ“Ž Did you mean? Found in
ofetch@1.0.0 (added) ofetch (16 thousand times more downloads) package.json,packages/nuxt/package.json,packages/test-utils/package.json
Pull request report summary
Issue Status
Install scripts βœ… 0 issues
Native code βœ… 0 issues
Bin script confusion βœ… 0 issues
Bin script shell injection βœ… 0 issues
Unresolved require βœ… 0 issues
Invalid package.json βœ… 0 issues
HTTP dependency βœ… 0 issues
Git dependency βœ… 0 issues
Potential typo squat ⚠️ 1 issue
Known Malware βœ… 0 issues
Telemetry βœ… 0 issues
Protestware/Troll package βœ… 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore ofetch@1.0.0

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@manniL
Copy link
Member

manniL commented Nov 15, 2022

it is a shorter name

Do you think the shorter name really worth all the migration for all packages using ohmyfetch now explicitly?

@pi0
Copy link
Member Author

pi0 commented Nov 15, 2022

Hmm will probably keep ohmyfetch as placeholder in a semver-major. Making it easier to migrate other packages. But for renaming really had to do this before v3 as you notice, it gets harder to break API or make renames as we have more users.

@manniL
Copy link
Member

manniL commented Nov 15, 2022

Hmm will probably keep ohmyfetch as placeholder in a semver-major.

That'd be good at least πŸ‘

But for renaming really had to do this before v3

Or not at all πŸ™ˆ

@pi0 pi0 marked this pull request as ready for review November 15, 2022 14:33
@pi0 pi0 merged commit b49f2a8 into main Nov 15, 2022
@pi0 pi0 deleted the feat/updates branch November 15, 2022 14:33
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants