This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(kit): add manually installed module to transpile #9187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pi0
reviewed
Nov 21, 2022
| } else if (moduleToInstall.getMeta) { | ||
| const meta = await moduleToInstall.getMeta() | ||
| if (meta.name) { | ||
| nuxt.options.build.transpile.push(meta.name) |
There was a problem hiding this comment.
This is dangerous and error prune. Name of module can be integration/library name not npm package of nuxt modue itself.
|
Thanks for the pull request dear @xtoolkit please keep doing this <3 Because of the mentioned reason above, i belive modules (ie: content) themselves should ensure their runtime dir is in the transpile array as needed as a safe method. Mapping name<>transform can result in unexpected behavior. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/content#1665
❓ Type of change
📚 Description
Following the previous merge request (#8963), i think we can support
NuxtModuletype.📝 Checklist