Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(vite): upgrade to vite 4 #9238

Merged
merged 7 commits into from Dec 12, 2022
Merged

feat(vite): upgrade to vite 4 #9238

merged 7 commits into from Dec 12, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Nov 21, 2022 •
edited

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR upgrades Nuxt to use Vite 4. The code changes:

  • adds a todo entry for unplugin until feat!: upgrade rollup to 3.x unjs/nitro#580 lands
  • resolves an issue with passing hasTransition: undefined to layouts even in built mode
  • updates the build size stats (smaller) for new output

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request vite labels Nov 21, 2022
@danielroe danielroe self-assigned this Nov 21, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 21, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@pi0 pi0 changed the title feat!: initial vite 4 implementation for testing feat: initial vite 4 implementation for testing Nov 22, 2022
@danielroe danielroe force-pushed the feat/vite-4 branch 3 times, most recently from 74c84fa to 5d84f51 Compare December 11, 2022 16:47
@danielroe danielroe changed the title feat: initial vite 4 implementation for testing feat(vite): upgrade to vite 4 Dec 11, 2022
@danielroe danielroe marked this pull request as ready for review December 11, 2022 18:39
@danielroe danielroe requested a review from pi0 December 11, 2022 18:39
This was referenced Dec 11, 2022
Closed
Closed
Closed
@vercel vercel bot temporarily deployed to Preview December 11, 2022 22:03 Inactive
@pi0
Copy link
Member

pi0 commented Dec 12, 2022 •
edited

@danielroe Do you mind to rebase and also bump nitropack to 2.x edge to move it forward and try on edge channel?

@danielroe
Copy link
Member Author

danielroe commented Dec 12, 2022 •
edited

@pi0 Type check now failing due to upstream nitro typing issue: unjs/nitro#751

@danielroe danielroe merged commit 5afcaca into main Dec 12, 2022
@danielroe danielroe deleted the feat/vite-4 branch December 12, 2022 15:22
@danielroe
Copy link
Member Author

Merging to test on edge. We'll revert back to non-edge nitropack before release.

@pi0 pi0 mentioned this pull request Dec 15, 2022
Closed
6 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Merged
danielroe added a commit that referenced this pull request Jan 21, 2023
@danielroe
feat(vite): upgrade to vite 4 (#9238)
d4f9d75
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
3.x enhancement New feature or request vite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0