refactor: move ipx to runtime servermiddleware
#264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add instructions for runtime ipx * improve dx with warning * don't inject ipx if user provides their own ipx mw
Codecov Report
@@ Coverage Diff @@
## main #264 +/- ##
==========================================
- Coverage 57.06% 55.01% -2.05%
==========================================
Files 23 23
Lines 524 538 +14
Branches 155 161 +6
==========================================
- Hits 299 296 -3
- Misses 225 242 +17
Continue to review full report at Codecov.
|
pi0
reviewed
May 12, 2021
Co-authored-by: pooya parsa <pyapar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits out the changes from #257 (without the automatic
nuxtrcinjection, which is pending for now).