Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): insert charset before title #18998

Merged
merged 5 commits into from Feb 13, 2023
Merged

Conversation

harlan-zw
Copy link
Contributor

@harlan-zw harlan-zw commented Feb 13, 2023

πŸ”— Linked issue

resolves #18936

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Don't know too much about vue-meta internals but looks like this does what it needs to.

Not sure why this didn't break any tests, seems a bit weird...?

But testing it manually seems to have worked.

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 13, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@harlan-zw harlan-zw changed the title fix: insert the charset before the title fix(meta): insert the charset before the title Feb 13, 2023
@harlan-zw harlan-zw changed the title fix(meta): insert the charset before the title fix(head): insert the charset before the title Feb 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Base: 66.42% // Head: 66.25% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (8247d6f) compared to base (49ea657).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x   #18998      +/-   ##
==========================================
- Coverage   66.42%   66.25%   -0.17%     
==========================================
  Files          93       93              
  Lines        4080     4090      +10     
  Branches     1154     1156       +2     
==========================================
  Hits         2710     2710              
- Misses       1107     1115       +8     
- Partials      263      265       +2     
Flag Coverage Ξ”
unittests 66.25% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
packages/vue-renderer/src/renderers/spa.js 0.00% <0.00%> (ΓΈ)
packages/vue-renderer/src/renderers/ssr.js 0.00% <0.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️

@danielroe danielroe changed the title fix(head): insert the charset before the title fix(vue-renderer): insert charset before title Feb 13, 2023
@danielroe danielroe merged commit 6cbe450 into 2.x Feb 13, 2023
@danielroe danielroe deleted the fix/meta-charset-order branch February 13, 2023 23:43
@danielroe danielroe mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants