New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-renderer): insert charset
before title
#18998
Conversation
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
Codecov ReportBase: 66.42% // Head: 66.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 2.x #18998 +/- ##
==========================================
- Coverage 66.42% 66.25% -0.17%
==========================================
Files 93 93
Lines 4080 4090 +10
Branches 1154 1156 +2
==========================================
Hits 2710 2710
- Misses 1107 1115 +8
- Partials 263 265 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β€οΈ
charset
before title
π Linked issue
resolves #18936
β Type of change
π Description
Don't know too much about vue-meta internals but looks like this does what it needs to.
Not sure why this didn't break any tests, seems a bit weird...?
But testing it manually seems to have worked.
π Checklist