Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): insert charset before title #18998

Merged
merged 5 commits into from Feb 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/vue-renderer/src/renderers/spa.js
Expand Up @@ -71,10 +71,18 @@ export default class SPARenderer extends BaseRenderer {
// BODY_ATTRS
meta.BODY_ATTRS = m.bodyAttrs.text()

// charset must come before the title to avoid encoding issues
let metaTags = m.meta.text()
const charset = m.meta.text({ charset: true })
if (charset) {
meta.HEAD += charset
metaTags = metaTags.replace(charset, '')
}

// HEAD tags
meta.HEAD =
meta.HEAD +=
m.title.text() +
m.meta.text() +
metaTags +
m.link.text() +
m.style.text() +
m.script.text() +
Expand Down
9 changes: 8 additions & 1 deletion packages/vue-renderer/src/renderers/ssr.js
Expand Up @@ -130,7 +130,14 @@ export default class SSRRenderer extends BaseRenderer {
})

if (meta) {
HEAD += meta.title.text() + meta.meta.text()
// charset must come before the title to avoid encoding issues
let metaTags = meta.meta.text()
const charset = meta.meta.text({ charset: true })
if (charset) {
HEAD += charset
metaTags = metaTags.replace(charset, '')
}
HEAD += meta.title.text() + metaTags
}

// Add <base href=""> meta if router base specified
Expand Down
6 changes: 6 additions & 0 deletions test/dev/basic.ssr.test.js
Expand Up @@ -86,6 +86,12 @@ describe('basic ssr', () => {
expect(html).toContain('<div><h1>I can haz meta tags</h1></div>')
expect(html).toContain('<script data-n-head="ssr" src="/body.js" data-body="true">')

// charset should be before title
const charset = html.indexOf('<meta data-n-head="ssr" charset="utf-8">')
const title = html.indexOf('<title>My title - Nuxt</title>')
expect(charset).toBeLessThan(title)
expect(charset).toBeGreaterThan(0)

const metas = window.document.getElementsByTagName('meta')
expect(metas[1].getAttribute('content')).toBe('my meta')
expect(consola.log).toHaveBeenCalledWith('Body script!')
Expand Down