-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix encoding issues with payload paths #8738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I would suggest we also decode url in generator when computing filesystem paths to ensure this does not implicitly happens again
Codecov Report
@@ Coverage Diff @@
## dev #8738 +/- ##
=======================================
Coverage 66.06% 66.06%
=======================================
Files 92 92
Lines 4013 4013
Branches 1105 1105
=======================================
Hits 2651 2651
Misses 1096 1096
Partials 266 266
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I've updated fix implementation to generator since rest of generated urls are encoded (browsers also anyway will encode request for http headers) Also discovered a second issue (client side) that manifest check is by decoded paths so we was skipping payload fetch for unicode routes... |
Types of changes
Description
closes #8679
Checklist: