Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix encoding issues with payload paths #8738

Merged
merged 10 commits into from Feb 2, 2021
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Feb 1, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

closes #8679

  • fix(generator): decode full static filesystem paths
  • fix(vue-app): check decoded path against manifest
  • fix(vue-app): prevent double encoding for urls

Checklist:

  • I have added tests to cover my changes
  • All new and existing tests are passing.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I would suggest we also decode url in generator when computing filesystem paths to ensure this does not implicitly happens again

packages/vue-renderer/src/renderers/ssr.js Outdated Show resolved Hide resolved
packages/vue-renderer/src/renderers/ssr.js Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix(vue-renderer): decode url for use in static payload folder fix(generator, vue-renderer): decode url for use in static payload folder Feb 1, 2021
@danielroe danielroe marked this pull request as ready for review February 1, 2021 16:57
@danielroe danielroe changed the title fix(generator, vue-renderer): decode url for use in static payload folder fix(vue-renderer): decode url for use in static payload folder Feb 1, 2021
@codecov-io
Copy link

codecov-io commented Feb 1, 2021

Codecov Report

Merging #8738 (81a19ef) into dev (3b02beb) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8738   +/-   ##
=======================================
  Coverage   66.06%   66.06%           
=======================================
  Files          92       92           
  Lines        4013     4013           
  Branches     1105     1105           
=======================================
  Hits         2651     2651           
  Misses       1096     1096           
  Partials      266      266           
Flag Coverage Δ
unittests 66.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/ssr.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b02beb...a34f403. Read the comment docs.

@danielroe danielroe self-assigned this Feb 1, 2021
@pi0 pi0 changed the title fix(vue-renderer): decode url for use in static payload folder fix(generator): decode full static paths when writing to disc Feb 2, 2021
@pi0 pi0 changed the title fix(generator): decode full static paths when writing to disc fix(generator): decode full static filesystem paths Feb 2, 2021
@pi0
Copy link
Member

pi0 commented Feb 2, 2021

I've updated fix implementation to generator since rest of generated urls are encoded (browsers also anyway will encode request for http headers)

Also discovered a second issue (client side) that manifest check is by decoded paths so we was skipping payload fetch for unicode routes...

@pi0 pi0 changed the title fix(generator): decode full static filesystem paths fix: fix encoding issues with payload paths Feb 2, 2021
@pi0 pi0 merged commit 6a8339e into dev Feb 2, 2021
@pi0 pi0 deleted the 8679-encoded-url-fs-path branch February 2, 2021 12:38
@pi0 pi0 mentioned this pull request Feb 9, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

encoded url causing error when accessing via static mode
3 participants