fix(builder): use path.resolve for pages dir #8832

atinux · 2021-02-15T17:56:24Z

Types of changes

Bug fix (a non-breaking change which fixes an issue)

Description

This allow to give a pages/ directory outside the srcDir. It should not break anything.

Checklist:

All new and existing tests are passing.

pi0

LGTM. Only one note: nuxtignore/ignore won't work for paths outside of its working dir (rootDir)

fix(builder): use path.resolve for pages dir

Verified

This commit was signed with the committer’s verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1

Verified
Learn about vigilant mode

1194b79

atinux requested a review from pi0 February 15, 2021 17:56

atinux added 2 commits February 15, 2021 19:06

chore: only use resolve for main pages dir

Verified

This commit was signed with the committer’s verified signature.

danielroe Daniel Roe

GPG key ID: 37103C9F8C1817F1

Verified
Learn about vigilant mode

65b971a

chore: update unit tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

dd275fa

pi0 approved these changes Feb 15, 2021

View reviewed changes

pi0 merged commit 8b1a704 into dev Feb 15, 2021

pi0 deleted the fix/resolve-pages-dir branch February 15, 2021 20:53

pi0 mentioned this pull request Feb 19, 2021

v2.15.1 #8855

Merged

danielroe added the 2.x label Jan 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

fix(builder): use path.resolve for pages dir #8832

fix(builder): use path.resolve for pages dir #8832

atinux commented Feb 15, 2021

pi0 left a comment

fix(builder): use path.resolve for pages dir #8832

fix(builder): use path.resolve for pages dir #8832

Conversation

atinux commented Feb 15, 2021

Types of changes

Description

Checklist:

pi0 left a comment

Choose a reason for hiding this comment