Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.15.1 #8855

Merged
merged 10 commits into from
Feb 19, 2021
Merged

v2.15.1 #8855

merged 10 commits into from
Feb 19, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 19, 2021

馃悰 Bug Fixes

馃挅 Thanks to

  • Harlan Wilton (@loonpwn)
  • Kenny (@kn3ny)

@pi0 pi0 merged commit 95daddf into 2.x Feb 19, 2021
const { app, router<%= (store ? ', store' : '') %> } = await createApp(ssrContext, { ...ssrContext.runtimeConfig.public, ...ssrContext.runtimeConfig.private })
const { app, router<%= (store ? ', store' : '') %> } = await createApp(ssrContext, ssrContext.runtimeConfig.private)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi0 was this an intentional change? it looks like the server went from receiving the public and private runtimeConfig to just receiving the private one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nothing as intended would you please open an issue with reproduction?

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants