chore(pkg): build for es2019 target

[pi0]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Use esbuild with taget: es2019 (using node* transform to CJS which breaks rollup chunks!) to build dist files. Fixes #9321 Closes #9322

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-commenter]

Codecov Report

Merging #9328 (62b1bd7) into dev (e687842) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #9328   +/-   ##
=======================================
  Coverage   65.16%   65.16%           
=======================================
  Files          94       94           
  Lines        4105     4105           
  Branches     1124     1124           
=======================================
  Hits         2675     2675           
  Misses       1152     1152           
  Partials      278      278           

Flag	Coverage Δ
unittests	65.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e687842...62b1bd7. Read the comment docs.

[clarkdo]

Nice change

[clarkdo]

OOC, what will be broken when using node ?

[pi0]

@clarkdo cli dist (using dynamic imports) was getting broken

[clarkdo]

Is dynamic import not transpiled ?
I guess a version<12.20 will work ? But es2019 look better to me as well.

[pi0]

Is dynamic import not transpiled ?

Actually it transpiled to cjs by esbuild when using node while shouldn't (rollup is esm native and supports cjs with CommonJS plugin). Maybe we could use node if there was a node-es target...

[clarkdo]

Right, so node version >= 12.20 in target should work as it fully supports dynamic import.

[clarkdo]

OK, it seems not evanw/esbuild#1084 (comment)