Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): remove unsupported nullish coalescing #9322

Closed
wants to merge 4 commits into from

Conversation

danielroe
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

closes #9321

Checklist:

  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #9322 (6735bf0) into dev (c56d484) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #9322      +/-   ##
==========================================
+ Coverage   65.13%   65.17%   +0.04%     
==========================================
  Files          94       94              
  Lines        4101     4106       +5     
  Branches     1124     1123       -1     
==========================================
+ Hits         2671     2676       +5     
  Misses       1152     1152              
  Partials      278      278              
Flag Coverage Δ
unittests 65.17% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/config/src/load.js 76.84% <100.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56d484...6735bf0. Read the comment docs.

clarkdo
clarkdo previously approved these changes May 21, 2021
@pi0
Copy link
Member

pi0 commented May 22, 2021

(pending to check possibility of adding esbuild to build scripts to avoid accidental syntax usage in the future) ~> #9328

@pi0 pi0 mentioned this pull request May 24, 2021
7 tasks
@pi0 pi0 closed this in #9328 May 24, 2021
@danielroe danielroe deleted the fix/nullish-coalescing branch May 24, 2021 17:43
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[edge] Nullish operator available with node 14 only
5 participants