fix(vue-renderer): respect injectScripts for target:static (#8912)

nuxt · Mar 1, 2021 · 07e97f1 · 07e97f1
1 parent 880fe4a
commit 07e97f1
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 38 deletions.
diff --git a/packages/vue-renderer/src/renderers/ssr.js b/packages/vue-renderer/src/renderers/ssr.js
@@ -177,7 +177,7 @@ export default class SSRRenderer extends BaseRenderer {
     const shouldHashCspScriptSrc = csp && (csp.unsafeInlineCompatibility || !containsUnsafeInlineScriptSrc)
     const inlineScripts = []
 
-    if (renderContext.staticAssetsBase) {
+    if (shouldInjectScripts && renderContext.staticAssetsBase) {
       const preloadScripts = []
       renderContext.staticAssets = []
       const { staticAssetsBase, url, nuxt, staticAssets } = renderContext

diff --git a/test/dev/full-static.test.js b/test/dev/full-static.test.js
@@ -14,55 +14,76 @@ let builder
 let server = null
 let generator = null
 
-describe('full-static', () => {
-  beforeAll(async () => {
-    const config = await loadFixture('full-static', {
-      generate: {
-        static: false,
-        dir: '.nuxt-generate'
-      }
-    })
-    const nuxt = new Nuxt(config)
-    await nuxt.ready()
+const generateAndStartServer = async (overrides) => {
+  const config = await loadFixture('full-static', {
+    generate: {
+      static: false,
+      dir: '.nuxt-generate'
+    },
+    ...(overrides || {})
+  })
+  const nuxt = new Nuxt(config)
+  await nuxt.ready()
+
+  builder = new Builder(nuxt)
+  builder.build = jest.fn()
+  generator = new Generator(nuxt, builder)
 
-    builder = new Builder(nuxt)
-    builder.build = jest.fn()
-    generator = new Generator(nuxt, builder)
+  await generator.generate()
 
-    await generator.generate()
+  const serve = serveStatic(distDir)
+  server = http.createServer((req, res) => {
+    serve(req, res, finalhandler(req, res))
+  })
+
+  port = await getPort()
+  server.listen(port)
+}
+
+describe('full-static', () => {
+  describe('with scripts', () => {
+    beforeAll(async () => await generateAndStartServer())
 
-    const serve = serveStatic(distDir)
-    server = http.createServer((req, res) => {
-      serve(req, res, finalhandler(req, res))
+    test('/payload (custom build.publicPath)', async () => {
+      const { body: html } = await rp(url('/payload'))
+
+      expect(html).toContain('<script src="https://cdn.nuxtjs.org/test/')
+      expect(html).toContain(
+        '<link rel="preload" href="https://cdn.nuxtjs.org/test/_nuxt/static/'
+      )
     })
 
-    port = await getPort()
-    server.listen(port)
-  })
+    test('/encoding/中文', async () => {
+      const { body: html } = await rp(url('/encoding/中文'))
 
-  test('/payload (custom build.publicPath)', async () => {
-    const { body: html } = await rp(url('/payload'))
+      const paths = ['encoding/中文/state.js', 'encoding/中文/payload.js']
+
+      paths.forEach((path) => {
+        const files = glob.sync(join(distDir, '**', path))
+        expect(html).toContain(encodeURI(path))
+        expect(files).toContainEqual(expect.stringContaining(path))
+      })
+    })
 
-    expect(html).toContain('<script src="https://cdn.nuxtjs.org/test/')
-    expect(html).toContain(
-      '<link rel="preload" href="https://cdn.nuxtjs.org/test/_nuxt/static/'
-    )
+    // Close server and ask nuxt to stop listening to file changes
+    afterAll(async () => {
+      await server.close()
+    })
   })
 
-  test('/encoding/中文', async () => {
-    const { body: html } = await rp(url('/encoding/中文'))
+  describe('without scripts', () => {
+    beforeAll(async () => await generateAndStartServer({ render: { injectScripts: false } }))
 
-    const paths = ['encoding/中文/state.js', 'encoding/中文/payload.js']
+    test('should not inject scripts', async () => {
+      const { body: html } = await rp(url('/payload'))
 
-    paths.forEach((path) => {
-      const files = glob.sync(join(distDir, '**', path))
-      expect(html).toContain(encodeURI(path))
-      expect(files).toContainEqual(expect.stringContaining(path))
+      expect(html).not.toContain('<script')
+      expect(html).not.toContain('<link')
     })
-  })
 
-  // Close server and ask nuxt to stop listening to file changes
-  afterAll(async () => {
-    await server.close()
+    // Close server and ask nuxt to stop listening to file changes
+    afterAll(async () => {
+      await server.close()
+    })
   })
 })