fix(types): use options from sass-loader rather than sass

* pins dependency in case of breaking change (-> webpack 5) in future closes #9085
nuxt · Mar 31, 2021 · 0a962ef · 0a962ef
1 parent 558227f
commit 0a962ef
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/packages/types/config/build.d.ts b/packages/types/config/build.d.ts
@@ -8,7 +8,7 @@ import { Options as AutoprefixerOptions } from 'autoprefixer'
 import { Options as FileLoaderOptions } from 'file-loader'
 import { Options as HtmlMinifierOptions } from 'html-minifier'
 import * as Less from 'less'
-import { Options as SassOptions } from 'sass'
+import { Options as SassOptions } from 'sass-loader'
 import { Options as OptimizeCssAssetsWebpackPluginOptions } from 'optimize-css-assets-webpack-plugin'
 import { Plugin as PostcssPlugin } from 'postcss'
 import { Options as PugOptions } from 'pug'

diff --git a/packages/types/package.json b/packages/types/package.json
@@ -22,7 +22,7 @@
     "@types/node": "^12.20.7",
     "@types/optimize-css-assets-webpack-plugin": "^5.0.3",
     "@types/pug": "^2.0.4",
-    "@types/sass": "^1.16.0",
+    "@types/sass-loader": "8.0.1",
     "@types/serve-static": "^1.13.9",
     "@types/terser-webpack-plugin": "^4.2.0",
     "@types/webpack": "^4.41.27",

diff --git a/yarn.lock b/yarn.lock
@@ -2542,6 +2542,13 @@
   resolved "https://registry.npmjs.org/@types/minimist/-/minimist-1.2.1.tgz#283f669ff76d7b8260df8ab7a4262cc83d988256"
   integrity sha512-fZQQafSREFyuZcdWFAExYjBiCL7AUCdgsk80iO0q4yihYYdcIiH28CcuPTGFgLOCC8RlW49GSQxdHwZP+I7CNg==
 
+"@types/node-sass@*":
+  version "4.11.1"
+  resolved "https://registry.npmjs.org/@types/node-sass/-/node-sass-4.11.1.tgz#bda27c5181cbf7c090c3058e119633dfb2b6504c"
+  integrity sha512-wPOmOEEtbwQiPTIgzUuRSQZ3H5YHinsxRGeZzPSDefAm4ylXWnZG9C0adses8ymyplKK0gwv3JkDNO8GGxnWfg==
+  dependencies:
+    "@types/node" "*"
+
 "@types/node@*":
   version "14.14.35"
   resolved "https://registry.npmjs.org/@types/node/-/node-14.14.35.tgz#42c953a4e2b18ab931f72477e7012172f4ffa313"
@@ -2613,7 +2620,16 @@
   dependencies:
     "@types/node" "*"
 
-"@types/sass@^1.16.0":
+"@types/sass-loader@8.0.1":
+  version "8.0.1"
+  resolved "https://registry.npmjs.org/@types/sass-loader/-/sass-loader-8.0.1.tgz#628eb80c30cb34ce622056f9b9a1606a8147dcd0"
+  integrity sha512-kum0/5Im5K2WdDTRsLtrXXvX2VJc3rgq9favK+vIdWLn35miWUIYuPkiQlLCHks9//sZ3GWYs4uYzCdmoKKLcQ==
+  dependencies:
+    "@types/node-sass" "*"
+    "@types/sass" "*"
+    "@types/webpack" "^4"
+
+"@types/sass@*":
   version "1.16.0"
   resolved "https://registry.npmjs.org/@types/sass/-/sass-1.16.0.tgz#b41ac1c17fa68ffb57d43e2360486ef526b3d57d"
   integrity sha512-2XZovu4NwcqmtZtsBR5XYLw18T8cBCnU2USFHTnYLLHz9fkhnoEMoDsqShJIOFsFhn5aJHjweiUUdTrDGujegA==