Skip to content

Commit

Permalink
fix: update types and make rendered sync
Browse files Browse the repository at this point in the history
  • Loading branch information
danielroe committed Jun 3, 2021
1 parent d9979a4 commit 537ae8f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion packages/types/app/index.d.ts
Expand Up @@ -72,7 +72,7 @@ export interface Context {
redirected: boolean
next: NextFunction
beforeRenderFns: Array<() => any>
afterRenderFns: Array<() => any>
beforeRenderHooks: Array<() => any>
fetchCounters: Record<string, number>
nuxt: {
layout: string
Expand All @@ -88,6 +88,7 @@ export interface Context {
error(params: NuxtError): void
nuxtState: NuxtState
beforeNuxtRender(fn: (params: { Components: VueRouter['getMatchedComponents'], nuxtState: NuxtState }) => void): void
beforeRender(fn: (params: { Components: VueRouter['getMatchedComponents'], nuxtState: NuxtState }) => void): void
enablePreview?: (previewData?: Record<string, any>) => void
$preview?: Record<string, any>
}
Expand Down
4 changes: 2 additions & 2 deletions packages/vue-app/template/server.js
Expand Up @@ -83,7 +83,7 @@ export default async (ssrContext) => {
// Create ssrContext.next for simulate next() of beforeEach() when wanted to redirect
ssrContext.redirected = false
ssrContext.next = createNext(ssrContext)
// deprectated: Used for beforeNuxtRender({ Components, nuxtState })
// deprecated: Used for beforeNuxtRender({ Components, nuxtState })
ssrContext.beforeRenderFns = []
// for beforeRender({ Components, nuxtState })
ssrContext.beforeRenderHooks = []
Expand Down Expand Up @@ -123,7 +123,7 @@ export default async (ssrContext) => {
// Deprecated: Call beforeNuxtRender() methods
await Promise.all(ssrContext.beforeRenderFns.map(fn => promisify(fn, { Components, nuxtState: ssrContext.nuxt })))

ssrContext.rendered = async () => {
ssrContext.rendered = () => {
// Call beforeRender() hooks
ssrContext.beforeRenderHooks.forEach(fn => fn({ Components, nuxtState: ssrContext.nuxt }))

Expand Down

0 comments on commit 537ae8f

Please sign in to comment.