fix(nuxt): do not compute useFetch key from headers (reverts #23462) (

#24333)
nuxt · Dec 11, 2023 · 90a4ea8 · 90a4ea8
1 parent 42d4bd0
commit 90a4ea8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/packages/nuxt/src/app/composables/fetch.ts b/packages/nuxt/src/app/composables/fetch.ts
@@ -211,12 +211,12 @@ function generateOptionSegments <_ResT, DataT, DefaultT>(opts: UseFetchOptions<_
     toValue(opts.method as MaybeRef<string | undefined> | undefined)?.toUpperCase() || 'GET',
     toValue(opts.baseURL),
   ]
-  for (const _obj of [opts.params || opts.query, opts.headers]) {
+  for (const _obj of [opts.params || opts.query]) {
     const obj = toValue(_obj)
     if (!obj) { continue }
 
     const unwrapped: Record<string, string> = {}
-    const iterator = Array.isArray(obj) ? obj : obj instanceof Headers ? obj.entries() : Object.entries(obj)
+    const iterator = Array.isArray(obj) ? obj : Object.entries(obj)
     for (const [key, value] of iterator) {
       unwrapped[toValue(key)] = toValue(value)
     }

diff --git a/test/nuxt/composables.test.ts b/test/nuxt/composables.test.ts
@@ -257,19 +257,13 @@ describe('useFetch', () => {
     expect.soft(getPayloadEntries()).toBe(baseCount + 2)
 
     /* @ts-expect-error Overriding auto-key */
-    await useFetch('/api/test', { headers: { id: '3' } }, '')
+    await useFetch('/api/test', { query: { id: '3' } }, '')
     /* @ts-expect-error Overriding auto-key */
-    await useFetch('/api/test', { headers: { id: ref('3') } }, '')
-    const headers = new Headers()
-    headers.append('id', '3')
+    await useFetch('/api/test', { query: { id: ref('3') } }, '')
     /* @ts-expect-error Overriding auto-key */
-    await useFetch('/api/test', { headers }, '')
+    await useFetch('/api/test', { params: { id: '3' } }, '')
     /* @ts-expect-error Overriding auto-key */
-    await useFetch('/api/test', { headers: [['id', '3']] }, '')
-    /* @ts-expect-error Overriding auto-key */
-    await useFetch('/api/test', { headers: [['id', ref('3')]] }, '')
-    /* @ts-expect-error Overriding auto-key */
-    await useFetch('/api/test', { headers: [[computed(() => 'id'), '3']] }, '')
+    await useFetch('/api/test', { params: { id: ref('3') } }, '')
     expect.soft(getPayloadEntries()).toBe(baseCount + 3)
   })
 })