fix(webpack): fallback for empty chunk name (#7667)

[release] Co-authored-by: pooya parsa <pyapar@gmail.com>
nuxt · Jul 4, 2020 · b4ffdab · b4ffdab
1 parent e3821ba
commit b4ffdab
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 12 deletions.
diff --git a/packages/webpack/src/config/client.js b/packages/webpack/src/config/client.js
@@ -74,22 +74,33 @@ export default class WebpackClientConfig extends WebpackBaseConfig {
 
     if (!this.dev && cacheGroups.default && cacheGroups.default.name === undefined) {
       cacheGroups.default.name = (_module, chunks) => {
-        // Use default name for single chunks
-        if (chunks.length === 1) {
-          return chunks[0].name || ''
-        }
-        // Use compact name for concatinated modules
-        let compactName = chunks
-          .filter(c => c.name)
-          .map(c => c.name)
+        // Map chunks to names
+        const names = chunks
+          .map(c => c.name || '')
+          .map(name => name
+            .replace(/[/\\]/g, '.')
+            .replace(/_/g, '')
+            .replace('pages.', '')
+          )
+          .filter(Boolean)
           .sort()
-          .map(name => name.replace(/[/\\]/g, '.').replace(/_/g, '').replace('pages.', ''))
-          .join('~')
 
+        // Fixes https://github.com/nuxt/nuxt.js/issues/7665
+        // TODO: We need a reproduction for this case (test/fixtures/shared-chunk)
+        if (!names.length) {
+          return 'commons/default'
+        }
+
+        // Single chunk is not common
+        if (names.length === 1) {
+          return names[0]
+        }
+
+        // Use compact name for concatinated modules
+        let compactName = names.join('~')
         if (compactName.length > 32) {
           compactName = hash(compactName)
         }
-
         return 'commons/' + compactName
       }
     }

diff --git a/test/fixtures/shared-chunk/components/lazy.vue b/test/fixtures/shared-chunk/components/lazy.vue
@@ -0,0 +1,5 @@
+<template>
+  <div>
+    Lazy Components
+  </div>
+</template>
diff --git a/test/fixtures/shared-chunk/nuxt.config.js b/test/fixtures/shared-chunk/nuxt.config.js
@@ -1,3 +1,4 @@
 export default {
-  components: true
+  components: true,
+  modern: true
 }
diff --git a/test/fixtures/shared-chunk/pages/index.vue b/test/fixtures/shared-chunk/pages/index.vue
@@ -1,5 +1,14 @@
 <template>
   <div>
+    <MyLazyComponent />
     <SharedVendor />
   </div>
 </template>
+
+<script>
+export default {
+  components: {
+    MyLazyComponent: () => import('~/components/lazy.vue')
+  }
+}
+</script>