Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling transitions within a route change prevents fully suspended navigation #14996

Closed
warflash opened this issue Sep 21, 2022 · 4 comments
Closed

Comments

@warflash
Copy link
Member

Environment


  • Operating System: Linux
  • Node Version: v16.14.2
  • Nuxt Version: 3.0.0-rc.8
  • Nitro Version: 0.5.4
  • Package Manager: npm@7.17.0
  • Builder: vite
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

https://stackblitz.com/edit/github-dfgsnr?file=pages%2Fother.vue

Describe the bug

Setting

definePageMeta({
  pageTransition: false,
});

skips the blocking useFetch is supposed to do and shows a blank view instead

Additional context

Repro uses rc8 due to stackblitz issues with rc11, tested with rc11 locally tho and same issue

Logs

No response

@danielroe danielroe self-assigned this Sep 21, 2022
@danielroe
Copy link
Member

Similar to changing layouts, removing transitions results in an entire rerender of the page. Doing so while transitioning routes effectively breaks the normal <Suspense>-powered blocking navigation.

In other words, the cause is the same as #14573.

@mmis1000
Copy link
Contributor

mmis1000 commented Oct 8, 2022

There is a new proposal about the <Suspense> that may be the proper fix of this bug.

vuejs/core#6736

By allow the child of the just created suspense boundary to be captured by parent boundary.
This may be able to pause the dom update until the page completely loaded.

@warflash
Copy link
Member Author

warflash commented Oct 8, 2022

Yeah, I'm hoping we will see that PR get merged soon 🙏

@danielroe danielroe changed the title pageTransition: false breaks useFetch navigation block disabling transitions within a route change prevents fully suspended navigation Nov 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe transferred this issue from nuxt/framework Jan 19, 2023
@danielroe
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants