Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: patch PR from vuejs/core introducing suspensible option to <Suspense> component #20285

Closed

Conversation

DamianGlowala
Copy link
Member

πŸ”— Linked issue

vuejs/core#6736

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR patches changes introduced in vuejs/core#6736 to the <Suspense> component, before they are merged in vuejs/core and hopefully paves a way to address some of the outstanding issues reported by Nuxt users:

#13814
#14860
#14996
#15144

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 14, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe requested a review from antfu April 14, 2023 22:50
@danielroe danielroe added the 3.x label Apr 14, 2023
@antfu
Copy link
Member

antfu commented Apr 15, 2023

Doing a patch like this won't affect userland, but also I would wish we didn't need to patch users either. I will talk to Evan to see how we could move forward for that PR. In the meanwhile, I see this PR does not include logic changes to adapt that feature, nor tests. You can help to do some testing so then we have a clear image of how many issues we could solve by introducing it.

Marking as a draft for now.

@DamianGlowala
Copy link
Member Author

DamianGlowala commented Apr 21, 2023

Closing, as the linked PR has been merged into vuejs/core

@DamianGlowala DamianGlowala deleted the feat/vue-core-suspense-patch branch April 21, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants