Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0-rc.12 typecheck runs throughout monorepo #15165

Closed
cuebit opened this issue Oct 14, 2022 · 0 comments · Fixed by nuxt/framework#8256
Closed

3.0.0-rc.12 typecheck runs throughout monorepo #15165

cuebit opened this issue Oct 14, 2022 · 0 comments · Fixed by nuxt/framework#8256

Comments

@cuebit
Copy link
Contributor

cuebit commented Oct 14, 2022

Environment

  • Operating System: Darwin
  • Node Version: v16.14.2
  • Nuxt Version: 3.0.0-rc.12-27762285.23ad303
  • Nitro Version: 0.5.5-27758232.d90c938
  • Package Manager: pnpm@7.13.4
  • Builder: vite
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

Browse on GitHub Open in StackBlitz

Describe the bug

RC.12 (#7726) includes workspaceDir in tsconfig include. In the context of monorepos that contain a mixture of environments, including the glob makes the entire monorepo visible to vue-tsc. Subsequently, issues are reported from unrelated workspaces. Moreover, as is apparent in larger monorepos, this can be a significant performance hit, particularly where pipelines are run in parallel.

Additional context

A workaround for now involves having to override includes in the project config that extends the nuxt generated tsconfig:

{
  "extends": "./.nuxt/tsconfig.json",
  "include": [
    "./.nuxt/nuxt.d.ts",
    "./**/*"
  ]
}

This is not sustainable given the include values can change between releases and such.

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants